Skip to content

Aof rewrite fix and test #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 27, 2021
Merged

Aof rewrite fix and test #754

merged 18 commits into from
May 27, 2021

Conversation

alonre24
Copy link
Collaborator

Refactoring and testing Redis AOF_Rewrite mechanism on ReidsAI types (probably for the first time...)

@alonre24 alonre24 requested a review from DvirDukhan May 20, 2021 12:53
@alonre24 alonre24 self-assigned this May 20, 2021
DvirDukhan
DvirDukhan requested changes May 22, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented May 24, 2021 •
edited
Loading

Codecov Report

Merging #754 (c0b058d) into master (ffbf441) will decrease coverage by 0.23%.
The diff coverage is 65.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
- Coverage   79.38%   79.15%   -0.24%     
==========================================
  Files          48       49       +1     
  Lines        7476     7651     +175     
==========================================
+ Hits         5935     6056     +121     
- Misses       1541     1595      +54
Impacted Files Coverage Δ
src/serialization/AOF/rai_aof_rewrite.c 0.00% <0.00%> (ø)
.../serialization/RDB/decoder/previous/v1/decode_v1.c 64.63% <ø> (ø)
...c/serialization/RDB/decoder/current/v2/decode_v2.c 67.87% <67.87%> (ø)
src/redisai.c 85.46% <100.00%> (+0.03%) ⬆️
src/serialization/RDB/decoder/decode_previous.c 75.00% <100.00%> (+8.33%) ⬆️
src/serialization/RDB/decoder/rai_rdb_decoder.c 100.00% <100.00%> (ø)
src/serialization/RDB/encoder/rai_rdb_encode.c 100.00% <100.00%> (ø)
src/serialization/RDB/encoder/v2/encode_v2.c 89.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7d6db...c0b058d. Read the comment docs.

@alonre24 alonre24 added ci-test and removed ci-test labels May 26, 2021
@alonre24 alonre24 added ci-test and removed ci-test labels May 26, 2021
@alonre24 alonre24 added ci-test and removed ci-test labels May 27, 2021
@alonre24 alonre24 merged commit 0a9d0f9 into master May 27, 2021
@alonre24 alonre24 deleted the AOF_rewrite_fix_and_test branch May 27, 2021 13:57
@DvirDukhan DvirDukhan mentioned this pull request May 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DvirDukhan DvirDukhan DvirDukhan approved these changes

Assignees

@alonre24 alonre24

Labels
ci-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alonre24 @DvirDukhan